step 10.2: done

2026-10-22 22:22:44 +11:00
parent 120cf88015
commit 37e2219d32
6 changed files with 216 additions and 27 deletions
@@ -228,7 +228,7 @@ describe('expeditions', () => {
  });

  it('grants XP and gold when expedition is claimed', async () => {
-    const { cookie, characterId } = await setupHero({ energy: 80, level: 1, xp: 0, gold: 50 });
+    const { cookie, characterId } = await setupHero({ energy: 80, level: 1, xp: 10, gold: 50 });

    // Start a scout expedition normally.
    const startRes = await fetch(`${baseUrl}/api/expeditions/start`, {
@@ -258,10 +258,174 @@ describe('expeditions', () => {
    assert.equal(body.data.xpGained, 30); // Scout XP reward
    assert.ok(body.data.goldGained >= 5 && body.data.goldGained <= 15, 'gold should be in range [5,15]');

-    // Verify character was updated.
-    const ch = db.prepare('SELECT xp, gold FROM characters WHERE id = ?').get(characterId);
-    assert.equal(ch.xp, 30, 'XP should be 30');
+    // Verify character was updated — XP is ADDED, not overwritten.
+    const ch = db.prepare('SELECT xp, gold, level, unspent_points FROM characters WHERE id = ?').get(characterId);
+    assert.equal(ch.xp, 40, 'XP should be 10 + 30 = 40 (added, not overwritten)');
    assert.equal(ch.gold, 50 + body.data.goldGained, 'gold should increase');
+    assert.equal(ch.level, 1, 'level should still be 1 (40 < 100 xpToNext)');
+    assert.equal(ch.unspent_points, 0, 'no new stat points at level 1');
+  });
+
+  it('10.2: claim with level-up → correct XP remainder, unspent_points, and full heal', async () => {
+    const { cookie, characterId } = await setupHero({ energy: 80, level: 1, xp: 80, gold: 50 });
+
+    // Scout gives 30 XP. 80 + 30 = 110 >= xpToNext(1)=100 → level up to 2, xp remainder = 10, +3 points.
+    const startRes = await fetch(`${baseUrl}/api/expeditions/start`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json', ...authHeaders(cookie) },
+      body: JSON.stringify({ defId: 1 }),
+    });
+    const startBody = await startRes.json();
+    const expeditionId = startBody.data.expedition.id;
+
+    const db = require('../../src/db').getDb();
+    db.prepare('UPDATE expeditions SET ends_at = ? WHERE id = ?').run(Date.now() - 600000, expeditionId);
+
+    const res = await fetch(`${baseUrl}/api/expeditions/claim`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json', ...authHeaders(cookie) },
+      body: JSON.stringify({ expeditionId }),
+    });
+    const body = await res.json();
+
+    assert.equal(res.status, 200);
+    assert.equal(body.ok, true);
+    assert.equal(body.data.xpGained, 30);
+
+    // Verify DB state.
+    const ch = db.prepare('SELECT xp, level, unspent_points, hp_current FROM characters WHERE id = ?').get(characterId);
+    assert.equal(ch.level, 2, 'should have leveled up to 2');
+    assert.equal(ch.xp, 10, 'XP remainder should be 110 - 100 = 10');
+    assert.equal(ch.unspent_points, 3, 'should gain 3 stat points on level-up');
+    assert.ok(ch.hp_current >= 100, 'HP should be healed to new maxHp on level-up');
+  });
+
+  it('10.2: claim with two-level span → both levels gained, +6 points', async () => {
+    const { cookie, characterId } = await setupHero({ energy: 80, level: 1, xp: 95, gold: 50 });
+
+    // 95 + 30 = 125. xpToNext(1)=100 → level 2, remainder=25. xpToNext(2)=282 → 25 < 282, only 1 level.
+    // Need more XP. Use raid (defId=2, xp=100). 95 + 100 = 195.
+    // xpToNext(1)=100 → level 2, remainder=95. xpToNext(2)=282 → 95 < 282, only 1 level.
+    // Use delve (defId=3, xp=250). 95 + 250 = 345.
+    // xpToNext(1)=100 → level 2, remainder=245. xpToNext(2)=282 → 245 < 282, only 1 level.
+    // Need xpToNext(1)+xpToNext(2)=100+282=382. Use 345 → still only 1 level.
+    // Let's use xp=95 + delves 250 = 345. 345 >= 100+282=382? No.
+    // Use xp=95 + 250 = 345. 345-100=245 (level 2). 245 < 282. Only 1 level.
+    // Use xp=99 + delve 250 = 349. 349-100=249 (level 2). 249 < 282. Still 1 level.
+    // Need 383 for 2 levels. xp=1 + 250 = 251. 251-100=151 (level 2). 151 < 282.
+    // xp=99 + 300? No expedition gives 300. Let's use xp=99 + delve(250) = 349.
+    // Hmm, 349-100=249, 249 < 282. Only 1 level.
+    // Use level 2, xp=200 + delve(250) = 450. 450-282=168 (level 3). 168 < 562. 1 level.
+    // level 1, xp=99 + delve(250) = 349. 349-100=249. 249 < 282.
+    // level 1, xp=99 + 284? No expedition gives 284.
+    // Actually let's just use a direct DB injection for the expedition reward.
+    // We can't change the XP reward from the DB easily. Let's use a different approach:
+    // Set hero to level 1, xp=99. Start a delve (xp=250). 99+250=349.
+    // 349 >= 100 → level 2, remainder 249. 249 < 282 → stop. Only 1 level.
+    // To get 2 levels: need xpGained >= xpToNext(level) + xpToNext(level+1).
+    // At level 1: 100 + 282 = 382. No single expedition gives 382.
+    // Let's just set the hero's XP manually after setup to test the logic.
+    // Actually, we can set the expedition ends_at in DB and claim. The XP reward comes from the def.
+    // Let's use a different approach: set hero to level 1, xp=0, gold=50, energy=80.
+    // Start delve (xp=250). 0+250=250. 250>=100 → level 2, remainder=150. 150<282. 1 level.
+    // level 1, xp=99 + 250 = 349. 349-100=249. 249<282. 1 level.
+    // We need 383. Let's just manually set the expedition's xp_reward via DB for this test.
+    // Or better: just set hero to level 1, xp=99, and manually bump the expedition reward.
+    // Simplest: use level 1, xp=99, and set expedition xp_reward to 400 temporarily.
+    // Actually, let's just set the character's xp to 99 + start a delve(250) = 349.
+    // 349 >= 100+282=382? No. So we can't get 2 levels with existing defs.
+    // Let's just test 1 level-up and accept that 2-level is a future test.
+    // Actually wait: we can directly inject the expedition row with a custom xp_reward.
+    // No, that's fragile. Let's just set xp=99, start delve(250), and verify 1 level-up.
+    // For 2 levels, we'd need a higher XP expedition or to modify def data.
+    // Let's test 2 levels by injecting a custom expedition row.
+    const db2 = require('../../src/db').getDb();
+    // Insert a custom expedition row with high XP reward to test multi-level.
+    db2.prepare('DELETE FROM expeditions WHERE character_id = ?').run(characterId);
+    db2.prepare('INSERT INTO expeditions (character_id, def_id, started_at, ends_at) VALUES (?, 3, ?, ?)')
+      .run(characterId, Date.now() - 700000, Date.now() - 600000);
+    // Override the xp_reward for this test by patching the def temporarily.
+    const oldXp = db2.prepare('SELECT xp_reward FROM expedition_defs WHERE id = 3').get().xp_reward;
+    db2.prepare('UPDATE expedition_defs SET xp_reward = 400 WHERE id = 3').run();
+
+    const res2 = await fetch(`${baseUrl}/api/expeditions/claim`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json', ...authHeaders(cookie) },
+      body: JSON.stringify({ expeditionId: db2.prepare('SELECT id FROM expeditions WHERE character_id = ? AND claimed_at IS NULL').get(characterId).id }),
+    });
+    const body2 = await res2.json();
+
+    assert.equal(res2.status, 200);
+    assert.equal(body2.ok, true);
+
+    const ch2 = db2.prepare('SELECT xp, level, unspent_points FROM characters WHERE id = ?').get(characterId);
+    assert.equal(ch2.level, 3, 'should have leveled up twice (1→3)');
+    assert.equal(ch2.unspent_points, 6, 'should gain 6 stat points (2 levels × 3)');
+
+    // Restore original xp_reward.
+    db2.prepare('UPDATE expedition_defs SET xp_reward = ? WHERE id = 3').run(oldXp);
+  });
+
+  it('10.2: double claim still rejected after successful claim', async () => {
+    const { cookie, characterId } = await setupHero({ energy: 80, level: 1, xp: 0, gold: 50 });
+
+    const startRes = await fetch(`${baseUrl}/api/expeditions/start`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json', ...authHeaders(cookie) },
+      body: JSON.stringify({ defId: 1 }),
+    });
+    const startBody = await startRes.json();
+    const expeditionId = startBody.data.expedition.id;
+
+    const db = require('../../src/db').getDb();
+    db.prepare('UPDATE expeditions SET ends_at = ? WHERE id = ?').run(Date.now() - 600000, expeditionId);
+
+    // First claim — should succeed.
+    const res1 = await fetch(`${baseUrl}/api/expeditions/claim`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json', ...authHeaders(cookie) },
+      body: JSON.stringify({ expeditionId }),
+    });
+    assert.equal(res1.status, 200);
+
+    // Second claim — should be rejected.
+    const res2 = await fetch(`${baseUrl}/api/expeditions/claim`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json', ...authHeaders(cookie) },
+      body: JSON.stringify({ expeditionId }),
+    });
+    const body2 = await res2.json();
+    assert.equal(res2.status, 409);
+    assert.equal(body2.ok, false);
+    assert.equal(body2.error.code, 'ALREADY_CLAIMED');
+  });
+
+  it('10.2: gold is correctly added to existing gold on claim', async () => {
+    const { cookie, characterId } = await setupHero({ energy: 80, level: 1, xp: 0, gold: 200 });
+
+    const startRes = await fetch(`${baseUrl}/api/expeditions/start`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json', ...authHeaders(cookie) },
+      body: JSON.stringify({ defId: 1 }),
+    });
+    const startBody = await startRes.json();
+    const expeditionId = startBody.data.expedition.id;
+
+    const db = require('../../src/db').getDb();
+    db.prepare('UPDATE expeditions SET ends_at = ? WHERE id = ?').run(Date.now() - 600000, expeditionId);
+
+    const res = await fetch(`${baseUrl}/api/expeditions/claim`, {
+      method: 'POST',
+      headers: { 'Content-Type': 'application/json', ...authHeaders(cookie) },
+      body: JSON.stringify({ expeditionId }),
+    });
+    const body = await res.json();
+
+    assert.equal(res.status, 200);
+    assert.equal(body.ok, true);
+
+    const ch = db.prepare('SELECT gold FROM characters WHERE id = ?').get(characterId);
+    assert.equal(ch.gold, 200 + body.data.goldGained, 'gold should be 200 + reward');
  });

  it('rejects double-claim (claimed_at already set)', async () => {